Repository navigation
Provide more useful comments - #326
Closed
colleirose wants to merge 1 commit into
Closed
colleirose wants to merge 1 commit into
colleirose wants to merge 1 commit into
Conversation
Contributor
|
This is changing too much at once.
|
Author
|
This doesn't remove nosmt, it just doesn't set it as many times. It won't affect the functionality, it just makes it simpler to remove if the user wants to. I also don't think I moved any settings around. But as for the comments only changes, I will make another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This provides more useful and up-to-date comments for some options, and only disables SMT in three different areas to make it simpler to remove if desired (
mitigations=auto,nosmt,nosmt=force,l1tf=full,force).Mandatory Checklist
Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint
Optional Checklist
The following items are optional but might be requested in certain cases.